Repository navigation
Conversation
These two rules require access to the GT.common library, which is only available with the GT package installed.
The mdx tests `#require "GT"`. Because dune sandboxes testing operations such as mdx, even tho the mdx tests are associated with the `GT` package, dune will not assume this means the GT package should be available to operations *insde* the mdx rules, unless the package dependency is made explicit.
This was referenced Oct 20, 2026
shonfeder
added a commit
to ocaml/opam-repository
that referenced
this pull request
Oct 21, 2026
mdx tests and camlp5 code gen assumes the package is available, thus requiring an explicit dependency on the package. The upstream fix is submitted at PLTools/GT#35. This bound will prevent noise from irrelevant revdeps failures for published versions.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three of the build targets were depending on the
GTpackage being in scope, but weren't declaring that dependency.From dune's perspective, this dependency specification has always been missing for these rules, but prior to 3.25 (release pending), the dependency isolation was too lax to catch the omission.
More context can be found at ocaml/dune#16617 (comment)