Skip to content

Fix package build deps - #35

Open
shonfeder wants to merge 2 commits into
PLTools:masterfrom
shonfeder:fix-package-build-deps
Open

shonfeder wants to merge 2 commits into
PLTools:masterfrom
shonfeder:fix-package-build-deps

Conversation

@shonfeder

Copy link
Copy Markdown

Three of the build targets were depending on the GT package being in scope, but weren't declaring that dependency.

From dune's perspective, this dependency specification has always been missing for these rules, but prior to 3.25 (release pending), the dependency isolation was too lax to catch the omission.

More context can be found at ocaml/dune#16617 (comment)

These two rules require access to the GT.common library, which is only
available with the GT package installed.
The mdx tests `#require "GT"`. Because dune sandboxes testing operations
such as mdx, even tho the mdx tests are associated with the `GT`
package, dune will not assume this means the GT package should be
available to operations *insde* the mdx rules, unless the package
dependency is made explicit.
shonfeder added a commit to ocaml/opam-repository that referenced this pull request Oct 21, 2026
mdx tests and camlp5 code gen assumes the package is available, thus
requiring an explicit dependency on the package. The upstream fix is
submitted at PLTools/GT#35. This bound will
prevent noise from irrelevant revdeps failures for published versions.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant