fix: surface activation/deactivation failures instead of reporting success

[snehar-nd]

Problem

When Activate fails, the UI reports "Activated successfully" and then refreshes the list with the user still deactivated. The real error only ever reached the browser console.

OutputResponse returns HTTP 200 with {statusCode: 5000, errorMessage} on failure, and the global interceptor only special-cases statusCode === 5002 (session expiry). So an API-level failure flows into the success callback:

(res) => {
  this.dialogService.alert(this.confirmMessage + 'd successfully', 'success');  // fires on failure too
  this.getAllUserDetails();
},
(err) => console.log('error', err),   // user sees nothing

Fix

• Success callback checks statusCode before alerting, and surfaces errorMessage when the call failed.
• Error callback raises the message instead of only logging it.

Scope

Only the userActivationDeactivation subscribe in activateDeactivate(). No change to the request, the confirm dialog, or the refresh-on-success behaviour.

What this does and doesn't do

This is error visibility, not the functional fix — on its own it won't make Activate work, it will make the failure legible. The activation failure itself is fixed in the companion PR, PSMRI/Admin-API#149 (an unguarded NPE in deletedUserDetails). Both are worth having: the swallowed error is what let this go undiagnosed, and it would hide the next failure too.

Independent of the backend PR; merge order doesn't matter.

Deliberately not included

The Activate button is gated *ngIf="!element.lockedDueToFailedAttempts && element.deleted === true", so a user who is both locked and deactivated gets no Activate button at all — they must be unlocked first. That may well be the intended flow (the Lock column's disabled state says "Activate the account before changing lock status"), so it's left alone rather than changed on assumption. Worth a separate decision.

Verification status

Prettier and eslint pass (lint-staged ran eslint --fix clean on commit). Not run in a browser — the behaviour change is in a callback that needs a real failing API response to exercise.

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 4a81a0dc-513a-45fa-838c-cacff8bd15f4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud