feat: optimize PWA icons and events page loading performance - #27
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the site’s PWA icon setup (switching to a new square icon) and refactors events.html to fetch event JSON once at page level, then initialize the calendar and event lists from the preloaded data.
Changes:
- Updated
site.webmanifestand multiple pages’<link rel="apple-touch-icon">to useimg/psugh-icon.webp. - Refactored
events.htmlto consolidatefetch()calls and to include “next meeting” in the “Kommende Treffen” list. - Updated
CHANGELOG.mdto document the icon and events-page refactor.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| site.webmanifest | Switches manifest icons/shortcuts to psugh-icon.webp and adds maskable entries. |
| scripts/_template.html | Updates apple-touch-icon reference to psugh-icon.webp. |
| ressourcen/try-catch.html | Updates apple-touch-icon reference to psugh-icon.webp. |
| ressourcen/throw-write-error.html | Updates apple-touch-icon reference to psugh-icon.webp. |
| ressourcen/terminating-errors.html | Updates apple-touch-icon reference; minor formatting change at EOF. |
| ressourcen/select-object.html | Updates apple-touch-icon reference to psugh-icon.webp. |
| ressourcen/invoke-webrequest.html | Updates apple-touch-icon reference to psugh-icon.webp. |
| ressourcen/index.html | Updates apple-touch-icon reference to psugh-icon.webp. |
| ressourcen/erroractionpreference.html | Updates apple-touch-icon reference; minor formatting change at EOF. |
| ressourcen/convertfrom-json.html | Updates apple-touch-icon reference to psugh-icon.webp. |
| index.html | Updates apple-touch-icon reference to psugh-icon.webp. |
| impressum.html | Updates apple-touch-icon reference to psugh-icon.webp. |
| events.html | Consolidates event loading, passes preloaded events into calendar, and merges “next meeting” into upcoming list. |
| CHANGELOG.md | Documents the new icon and events page refactor. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+302
to
+308
| pastEvents.forEach(event => { | ||
| calendarEvents.push({ | ||
| date: new Date(event.date), | ||
| title: event.title, | ||
| type: 'past' | ||
| }); | ||
| }); |
Comment on lines
+327
to
+335
| if (currentMeeting) { | ||
| allUpcomingEvents.push({ | ||
| date: currentMeeting.date, | ||
| dateDisplay: currentMeeting.date, | ||
| title: currentMeeting.description || 'Nächstes Treffen', | ||
| description: currentMeeting.description, | ||
| topics: currentMeeting.topics | ||
| }); | ||
| } |
…arget sizes for WCAG compliance
…lse-positive noindex warnings
…dar tooltips, and schemas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates event loading, shows next meeting in upcoming list, and adds square PWA icon.