Skip to content

fix: resolve actor names from accounts #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pikann merged 1 commit into from
Oct 12, 2026
Merged

fix: resolve actor names from accounts #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions backend/webhooks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,7 @@ func (p *webhookPlugin) buildEventData(topic string, payload map[string]any) (ma
// resolvable actor at all (id and name fall back to "" and "Someone").
func (p *webhookPlugin) resolveActor(topic string, payload map[string]any) (name, id, actorType string) {
if agentID, ok := payload["actor_agent_id"].(string); ok && agentID != "" {
name = p.lookupName(`SELECT name FROM agents WHERE id = $1`, agentID)
name = p.lookupName(`SELECT name FROM accounts WHERE id = $1 AND kind = 'agent'`, agentID)
if name == "" {
name = "An agent"
}
Expand All @@ -629,11 +629,11 @@ func (p *webhookPlugin) resolveActor(topic string, payload map[string]any) (name
switch topic {
case "task.comment.added", "task.comment.updated", "task.comment.deleted", "comment":
name = p.lookupName(
`SELECT u.full_name AS name FROM project_members pm JOIN users u ON u.id = pm.user_id WHERE pm.id = $1`,
`SELECT ac.name AS name FROM project_members pm JOIN accounts ac ON ac.id = pm.account_id WHERE pm.id = $1`,
actorID,
)
default:
name = p.lookupName(`SELECT full_name AS name FROM users WHERE id = $1`, actorID)
name = p.lookupName(`SELECT name FROM accounts WHERE id = $1`, actorID)
}
if name == "" {
name = "Someone"
Expand Down
Loading