Repository navigation
feat: add AppPageProps interface for full-bleed app page support - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
AppPagePropstype for the newapp.pageextension point, so plugins can register a full-bleed, top-level page that no sidebar lists.src/extension-points.ts: newAppPageProps extends BaseExtensionProps, added to theExtensionPointPropsunion and to the extension point list in the header comment.src/index.ts: exportsAppPageProps.Why
A plugin sometimes needs its own URL on the Paca origin. The usual case is the address an external service redirects the browser back to, such as an App-installation or OAuth callback.
app.pagerenders at/plugin-pages/:pluginId/:slug(nav itemscope: "app").Behavior notes (documented in the type's JSDoc)
apiclient calls the plugin's own backend as that user. It has noprojectId(global scope).window.locationand treated as untrusted input.Notes
AppPagePropsadds no props beyondBaseExtensionProps, likeAdminPageProps.app.pageextension point support in the Paca app.