KR2SortTree - #17
Open
Palezehvat wants to merge 1 commit into
Open
KR2SortTree#17Palezehvat wants to merge 1 commit into
Palezehvat wants to merge 1 commit into
Conversation
| for (int i = 0; i < size; ++i) { | ||
| printf("%d ", arrayOut[i]); | ||
| } | ||
| } |
| } | ||
| } | ||
|
|
||
| int j = 0; |
There was a problem hiding this comment.
О, глобальная переменная, минус два балла :) Надо было передавать как параметр по указателю везде, где она нужна.
|
|
||
| #include <stdbool.h> | ||
|
|
||
| typedef struct Node Node; |
There was a problem hiding this comment.
Это тут, к сожалению, не нужно, потому что этот модуль буквально ничего про tree внешнему миру не предоставляет
|
|
||
| typedef struct Node Node; | ||
|
|
||
| void addArrayToTree(int arrayOut[], int size); |
There was a problem hiding this comment.
Неудачное название функции. Она не добавляет массив в дерево, она сортирует массив
Comment on lines
+17
to
+18
| Tree* tree = calloc(1, sizeof(tree)); | ||
| return tree; |
There was a problem hiding this comment.
Suggested change
| Tree* tree = calloc(1, sizeof(tree)); | |
| return tree; | |
| return calloc(1, sizeof(tree)); |
|
|
||
| void addToTree(Tree* tree, int value) { | ||
| if (tree == NULL) { | ||
| return ; |
There was a problem hiding this comment.
Suggested change
| return ; | |
| return; |
There was a problem hiding this comment.
Но ещё надо бы как-то просигнализировать вызывающему, что всё плохо
|
|
||
| void backOrderClear(Tree* tree) { | ||
| helpBackOrderClear(tree->root); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.