LexerOfNumbers - #25
Open
Palezehvat wants to merge 2 commits into
Open
Palezehvat wants to merge 2 commits into
Palezehvat wants to merge 2 commits into
Conversation
yurii-litvinov
suggested changes
Dec 20, 2022
| for (size_t i = 0; i < sizeString; ++i) { | ||
| switch (state) | ||
| { | ||
| case(0): |
There was a problem hiding this comment.
Suggested change
| case(0): | |
| case 0: |
|
|
||
| bool isTheSequenceANumber(const char* string) { | ||
| size_t sizeString = strlen(string); | ||
| int state = 0; |
There was a problem hiding this comment.
Хочется, чтобы state был enum-ом, с разумными названиями элементов
| } | ||
| return false; | ||
| case(2): | ||
| if (string[i] == 'E' && string[i-1] != '.') { |
There was a problem hiding this comment.
Suggested change
| if (string[i] == 'E' && string[i-1] != '.') { | |
| if (string[i] == 'E' && string[i - 1] != '.') { |
Но вообще нет, автомат так не умеет. string[i - 1], как и другие факты из прошлого, кодируются состояниями. Иначе таблица переходов была бы трёхмерной.
| } | ||
|
|
||
| } | ||
| return string != NULL && string[sizeString - 1] != '+' && string[sizeString - 1] != '-' && string[sizeString - 1] != 'E'; |
There was a problem hiding this comment.
Так автоматы тоже не умеют. Надо либо явно return false при неверном переходе, либо return true из допускающего состояния
| #pragma once | ||
| #include <stdbool.h> | ||
|
|
||
| bool isTheSequenceANumber(const char* string); No newline at end of file |
| printf("ERROR...\n"); | ||
| return -1; | ||
| } | ||
| printf("Input string no more than 100symbols\n"); |
There was a problem hiding this comment.
Suggested change
| printf("Input string no more than 100symbols\n"); | |
| printf("Input string no more than 100 symbols\n"); |
| #include <stdio.h> | ||
|
|
||
| int main() { | ||
| if (test()) { |
| #pragma once | ||
| #include <stdbool.h> | ||
|
|
||
| bool test(); No newline at end of file |
Comment on lines
+1
to
+2
| #pragma once | ||
| #include <stdbool.h> |
There was a problem hiding this comment.
Suggested change
| #pragma once | |
| #include <stdbool.h> | |
| #pragma once | |
| #include <stdbool.h> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.