Routers - #11
Open
Palezehvat wants to merge 11 commits into
Open
Routers#11Palezehvat wants to merge 11 commits into
Palezehvat wants to merge 11 commits into
Conversation
yurii-litvinov
suggested changes
May 25, 2023
yurii-litvinov
left a comment
yurii-litvinov
left a comment
There was a problem hiding this comment.
Можно было обойтись в три раза меньшим количеством строк кода. И оооочень неаккуратно.
| /// Returns graph size | ||
| /// </summary> | ||
| /// <returns>Graph size</returns> | ||
| /// <exception cref="NullPointerException">If graph null throw exception</exception> |
| { | ||
| if (IsEmpty()) | ||
| { | ||
| throw new NullPointerException(); |
There was a problem hiding this comment.
Тут та же проблема, я как пользователь хочу знать, в чём я неправ и как это исправить. NullPointerException мне никак в этом не поможет, тем более что в C# нет pointer-ов.
| { | ||
| throw new NullPointerException(); | ||
| } | ||
| return GraphByList.sizeGraph; |
There was a problem hiding this comment.
nullability недоволен, надо поправить
| /// </summary> | ||
| /// <returns>Graph size</returns> | ||
| /// <exception cref="NullPointerException">If graph null throw exception</exception> | ||
| public int ReturnSizeGraph() |
There was a problem hiding this comment.
Это лучше было сделать свойством, причём просто Size
| /// <param name="sizeWay">Path Size</param> | ||
| public void AddArcs(int fromVertex, int toVertex, int sizeWay) | ||
| { | ||
| if(GraphByList == null) |
There was a problem hiding this comment.
Suggested change
| if(GraphByList == null) | |
| if (GraphByList == null) |
| /// <exception cref="InvalidFileException">Throws an exception if the entry in the file is uncorrected</exception> | ||
| public bool WorkWithFile(string filePath, string fileAfter) | ||
| { | ||
| var file = new StreamReader(filePath); |
There was a problem hiding this comment.
Suggested change
| var file = new StreamReader(filePath); | |
| using var file = new StreamReader(filePath); |
| ++i; | ||
| while (Char.IsDigit(line[i])) | ||
| { | ||
| mainVertex = mainVertex * 10 + line[i] - 48; |
| using Routers; | ||
| public class Tests | ||
| { | ||
| Graph graph; |
There was a problem hiding this comment.
Suggested change
| Graph graph; | |
| private Graph graph; |
Comment on lines
+3
to
+4
| using Routers; | ||
| public class Tests |
There was a problem hiding this comment.
Suggested change
| using Routers; | |
| public class Tests | |
| using Routers; | |
| public class Tests |
| private static IEnumerable<TestCaseData> GraphForTest | ||
| => new TestCaseData[] | ||
| { | ||
| new TestCaseData(new Graph()), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Дз по роутерам