Repository navigation
chore(release): 同步 dev 到 main - #212
Merged
Merged
Conversation
- 新增自审拦截:申请人不能审批自己的经费申请(403)
- 新增驳回后重新提交:POST /api/budget/applications/{id}/resubmit
- 新增审核历史查询:GET /api/budget/applications/{id}/reviews
- 前端增加重新提交按钮+对话框、审核历史时间线展示
- 新增 ResubmitBudgetApplicationRequest schema
- 新增 BudgetApprovalFlowTests 测试
Closes #118
- req.Amount (double?) 与 decimal 类型不匹配,改用显式转换 - req.Type 为 string? 而非 enum,改用 NullIfBlank + NormalizeApplicationType - BudgetManagement.vue 通过 Prettier 格式化
CI openapi-generator 将 ResubmitBudgetApplicationRequest.type 生成为 non-nullable TypeEnum 而非 string?,现通过 Enum.IsDefined 检测客户端 是否传入了 type 字段。
补齐审核历史权限、重提幂等与可空类型处理,并使用隔离 SQLite 关系型测试覆盖自审和驳回重提状态流转。
将 nullable 移入 BudgetApplicationType schema,避免 OpenAPI 3.0 中 allOf 引用不接受 null,并补充显式 null 的回归测试。
区分省略字段与显式 null,允许重新提交时清空关联活动和明细,并刷新新的提交时间。
为重提接口的错误状态统一补充 ApiError JSON schema,并增加契约回归测试。
…workflow feat(budget): 优化经费申请审批流,增加自审拦截、驳回重提与审核历史
认证容器改为占满视口高度,并使用对称上下留白垂直居中文字和表单面板。
验证认证容器使用完整视口高度、垂直居中和对称上下留白,防止布局回归。
…enter fix(auth): 垂直居中登录注册页面内容
Palind-Rome
requested review from
Aphrody-Dy,
Chaotze,
FEnjoyit,
SE-MAX-F,
YoumiaHina,
chiyuuu0123,
jyybacpg,
onnisama and
wendaining
as code owners
September 1, 2026 08:25
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (17)
Walkthrough新增预算审核历史查询和驳回申请重新提交功能。后端、OpenAPI 契约、TypeScript API 客户端、预算管理页面和集成测试同步更新。认证页面改为完整视口高度布局。 Changes预算申请审核闭环
认证页面布局
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant BudgetManagementVue
participant DefaultApi
participant BudgetController
participant ClubHubDbContext
BudgetManagementVue->>DefaultApi: 查询审核历史或提交重新提交请求
DefaultApi->>BudgetController: GET reviews 或 POST resubmit
BudgetController->>ClubHubDbContext: 查询审核记录或更新预算申请
ClubHubDbContext-->>BudgetController: 返回数据
BudgetController-->>DefaultApi: 返回审核记录或预算申请
DefaultApi-->>BudgetManagementVue: 更新页面状态
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
发布内容
将当前
dev分支已完成并通过审查的改动同步至main。本次主要包含:
合并前以 GitHub required checks 与分支保护规则为准。
Summary by CodeRabbit