Skip to content

feat(oracle): trim and reject empty/whitespace oracle keys (#684) #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
infimum90 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(oracle): trim and reject empty/whitespace oracle keys (#684) #768

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/oracle/middleware/oracle-key-validation.middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,20 @@ export class OracleKeyValidationMiddleware implements NestMiddleware {
key = pathKey;
}

// Trim whitespace and reject empty or whitespace‑only keys
if (key !== undefined) {
key = key.trim();
if (key.length === 0) {
this.logger.warn('Rejected empty or whitespace‑only oracle key');
throw new BadRequestException('Invalid oracle key format. Expected ' + ORACLE_KEY_FORMAT_DESCRIPTION + '.');
}
}

if (!key) {
return next();
}

if (!isValidOracleKeyFormat(key)) {
if (key !== undefined && !isValidOracleKeyFormat(key)) {
this.logger.warn(`Rejected malformed oracle key: ${key}`);
throw new BadRequestException(
`Invalid oracle key format. Expected ${ORACLE_KEY_FORMAT_DESCRIPTION}.`,
Expand Down