Repository navigation
fix: resolve issues #752, #751, #750, and #749 - #771
Merged
nonsobethel0-dev merged 2 commits intoOct 18, 2026
Merged
nonsobethel0-dev merged 2 commits into
nonsobethel0-dev merged 2 commits into
Conversation
|
@Miss-shelby Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This Pull Request addresses and resolves the following 4 issues:
1. Issue #752 — Validate Oracle reading numeric value is finite
@IsFiniteNumber()custom validation decorator insrc/oracle/dto/oracle-reading.dto.tsthat explicitly rejectsNaN,Infinity, and-Infinity.OracleReadingDtowith validation ensuring numeric values are finite numbers and returning clear validation errors.OracleFeedRequestDtolatitude and longitude coordinates.src/oracle/dto/oracle-reading.dto.spec.ts(34 tests passing).2. Issue #751 — Handle webhook delivery redirects to different domains
src/common/events/webhooks.service.tsHTTP dispatch to setredirect: 'manual'.src/common/events/webhooks.service.spec.tstesting301,302,307, and308cross-domain and same-domain redirects.3. Issue #750 — Redact database connection string in connection failure logs
src/prisma/prisma.service.tswithgetHostAndDatabaseFromUrl()andsanitizeConnectionError()to redact connection URLs (protocol://***:***@host/db).[target: host/database], completely omitting credentials, passwords, and sensitive query parameters.src/prisma/prisma.service.spec.tsverifying error logs and exceptions never expose credentials.4. Issue #749 — Implement cursor-based pagination for claims
src/claims/claims.service.tsusing Prismacursor: { id: cursor }, skip: 1, take: limit + 1.src/claims/claims.controller.tswith query parameter@Query('cursor')ongetClaimsByWalletQueryandgetClaimHistory.PaginatedResponseDtowithnextCursorandhasMorefields.pageandlimit.docs/CLAIMS_PAGINATION.md.src/claims/claims.pagination.spec.tsandsrc/claims/claims.controller.spec.ts.Closing Keywords