Repository navigation
fix: input maxLength, claim render stability, modal inert, full-address copy (#736-#739) - #777
Merged
nonsobethel0-dev merged 4 commits intoOct 16, 2026
Conversation
Unbounded paste into search, coverage, duration, coordinates, flight number, and oracle params could overflow UI and stress backend parsers. Introduce MAX_INPUT_LENGTHS and apply it across all text inputs. Fixes Parashield-Protocol#736
…nders Document that ClaimHistoryTable is presentational and that sort is memoized on claims+sort only, so countdown ticks and export-menu state cannot recreate fetch work. Stabilize useClaims load identity. Fixes Parashield-Protocol#737
Background content stayed in the accessibility tree while a modal was open. Mark #__next aria-hidden (and inert where supported) and portal the dialog to document.body so it remains reachable. Restored on close. Fixes Parashield-Protocol#738
The displayed address is truncated, so users assumed the copy button copied that short form. CopyButton now always writes the full text and shows a success toast containing the complete value. Fixes Parashield-Protocol#739
|
@benfoster-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
❌ Deploy Preview for boisterous-sunshine-dd4c4c failed.
|
nonsobethel0-dev
merged commit Oct 16, 2026
ca552ff
into
Parashield-Protocol:main
0 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #736
Fixes #737
Fixes #738
Fixes #739
What changed
MAX_INPUT_LENGTHSand enforcemaxLengthon search, coverage, duration, lat/lng, flight number, oracle params, and deposit/withdraw amountsuseClaimsload identity depends only onwalletAddress;ClaimHistoryTablesort stays memoized onclaims+sortso parent re-renders (export menu, countdown ticks) cannot retrigger fetch workdocument.bodyand marks#__nextaria-hidden/inertwhile open, restoring both on closeCopyButtonalways writes the fulltextprop and shows a success toast containing the complete value;WalletAddressDisplaypasses the full address even when the span is truncatedWhy
How to test
npm testaria-hidden/inert; close → restoredNotes
maxLengthontype="number"is advisory in some browsers; value is still validated at parse/submitcreatePortaltodocument.body— any tests that assumed in-tree dialog DOM may need the portal