Repository navigation
feat: ConfirmModal, debounce leading edge, lazy PostHog, Ctrl+K search - #779
Merged
Conversation
- Parashield-Protocol#751: Add ConfirmModal component using the app's Modal for branded confirmations with focus trap, ARIA, and confirm/cancel actions. Supports destructive variant with red styling. - Parashield-Protocol#750: Add leading option to useDebounce hook — fires the first change immediately and debounces subsequent ones, matching lodash.debounce semantics. - Parashield-Protocol#741: Lazy-load PostHog via dynamic import() deferred to requestIdleCallback (1.5s fallback) so analytics never blocks the main thread during first paint. Pageview tracking unchanged. - Parashield-Protocol#740: Register global Ctrl+K/Cmd+K shortcut to focus the search input from anywhere. Show shortcut hint in placeholder. Add entry to KeyboardShortcutHelpModal.
|
@brightpixel-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
❌ Deploy Preview for boisterous-sunshine-dd4c4c failed.
|
…ytics-search-shortcut
nonsobethel0-dev
merged commit Oct 16, 2026
7ac234c
into
Parashield-Protocol:main
0 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #740
Closes #741
Closes #750
Closes #751
What changed
ConfirmModalcomponent using the app's brandedModalfor destructive-action confirmations. Supports confirm/cancel actions, destructive variant (red styling), focus trap, and ARIA attributes from the underlying Modal.leadingoption touseDebouncehook. Whenleading: true, the first change fires immediately and subsequent calls within the delay window are debounced as usual — matchinglodash.debouncesemantics for search-as-you-type on fast connections.import('posthog-js')dynamic import deferred torequestIdleCallback(1.5ssetTimeoutfallback) so analytics never blocks the main thread during first paint. Pageview tracking and queue behavior unchanged.Ctrl+K/Cmd+Kkeyboard shortcut to focus the search input from anywhere on the page. Added shortcut hint to the placeholder text andKeyboardShortcutHelpModal.How to verify
Ctrl+K(orCmd+Kon macOS) from any page — search input gets focus and text is selected.KeyboardShortcutHelpModallists the new shortcut.useDebounce(value, 500, { leading: true })fires the first change immediately.