Repository navigation
Conversation
Refs Parcel-Protocol#121, Parcel-Protocol#125, Parcel-Protocol#128 and Parcel-Protocol#173. Independent local issue branches retain one-issue scope; the integration branch also includes existing compile and stylesheet repairs.
|
@0takuc0mrade Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
0takuc0mrade
marked this pull request as ready for review
October 19, 2026 19:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds three read-only Stellar tools and a risk/review workflow for ticket transfers. Implements all four assigned issues:
Scope proof
The three tools are complete, independent slices in
features/offer-inspector/,features/multisig-analyzer/andfeatures/sponsorship-planner/(26 files each). Transfer-risk logic lives incore/transfer-risk/with integration incore/invariants/. No generated registry output or shared route/navigation lists are included.Also removes three existing compile blockers (duplicate claimable-balance formatting, duplicate faucet hook declarations, malformed scanner copy) and restores Tailwind scanning of
core/andfeatures/, needed to render the tools in the existing app.How to test
The completed focused run passes 121 tests in 21 files. Scoped ESLint is clean; all three feature-contract checks and the boundary check pass. axe passes on idle/result markup. Six desktop/mobile browser checks pass, exercising request failure, recovery, successful results and no document overflow. Both networks are supported; transport tests use deterministic mocked Horizon responses.
For manual UI review, start
npm run devand visit/tools/offer-inspector,/tools/multisig-analyzerand/tools/sponsorship-planner. Supply public fixture inputs from each slice'sfixtures/; verify a valid result, an invalid-address error and a mocked 503/retry. Secret keys are rejected before requests and cleared instead of echoed. These tools never sign or submit transactions.Integration status
This is a draft against the currently available default branch,
main. The issue templates requiredev, but upstream currently has nodevbranch. Retarget todevwhen that integration branch is available.Full repository checks remain blocked by baseline failures:
npm run checkreports 36 existing lint errors, and production bundling compiles before type checking fails on the missingRoleexport incore/admin-config/store.ts:23. Unrelated domain-test failures were reproduced against the untouched baseline. The completed verification above covers the changed paths.Multisig results describe current envelope authorization, not complete transaction validity or Soroban contract auth. Sponsorship estimates exclude fees and new trading liabilities. Transfer review extends the existing server-domain library; its state/audit must be committed with ownership and nonces through the transactional/CAS adapter, with principals, device evidence, policy and clock supplied by trusted server context. No new public mutation endpoint or persistence service is introduced.
Evidence
Verification details. Screenshots use deterministic public fixture data.
#121 — Account Offers Inspector: idle, loading, error and result
Mobile result
#125 — Multisig Signature Weight Analyzer: idle, loading, error and result
Mobile result
#128 — Sponsorship and Reserve Planner: idle, loading, error and result
Mobile result
Checklist
npm run checkpasses (baseline failures described above).devintegration branch when available.