Repository navigation
侧边栏:标题栏下加字幕下拉框,和弹窗、专注模式选同一条字幕 - #428
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改了什么
侧边栏视频的标题栏下加一行「字幕」下拉框(弹窗那一条的样式,32px,普通网页不显示)。开着侧边栏切视频时,不用再开弹窗去选字幕。
popup-select-subtitle→ 视频页switchSubtitle。下拉框的选项由新的MdgSites.fillSubtitleSelect画,弹窗、专注模式原来各一份,改成三处共用。mdg-subtitle-changed,侧边栏收到后重读,弹窗、专注模式里换的也跟着变。sidepanel-state.js的 keep 分支)。验证
node scripts/selftest.mjs:39 个通过。新加的 sidepanel / sidepanel-state 测试去掉修复后会失败。node scripts/smoke.mjs通过。