Repository navigation
侧边栏：字幕下拉框后面加「刷新」，和弹窗的一样 - #429
Merged
Merged
Conversation
重新读视频和字幕；读的时候图标转圈、不能点，读失败变红，下次读成功再恢复。「重试」也走同一个函数，一样转圈。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改了什么
侧边栏「字幕」一行的右边加一个「刷新」，图标和弹窗右上角的那个一样。刷新就是重新读视频和字幕，所以放在字幕旁边；普通网页没有这一行，也就没有这个按钮。刷新和设置上下对齐，字幕栏和平台下拉框右端对齐。
refreshContextManually（refresh: true）。读的时候图标转圈、不能点；读失败变红，下次读成功再恢复，和弹窗的is-error一样。conventions.selftest.js的 3a 允许清单加一条：读的时候直接disabled，finally 打开，和弹窗的setBusy同理。dev-sidepanel/index.html按新的sidepanel.html重新生成。验证
node scripts/selftest.mjs：39 个通过。新加的 sidepanel 测试查读的时候转圈、不能点，读失败变红，读成功恢复。node scripts/smoke.mjs通过。dev-sidepanel/index.html：刷新和设置都在 x 340–368，字幕栏和平台下拉框右端都在 332；看了平时、读取中、读取失败三种样子；点一下读完后恢复原样。