Repository navigation
设置：接口地址去斜杠和取 origin 只在 settings.js 写一份 - #435
Merged
Merged
Conversation
设置页和后台各有一份相同的 trimBaseUrl / urlOrigin，合到 MdgSettings。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改了什么
设置页和后台各有一份一样的「接口地址去空格和结尾斜杠」（
normalizeBaseUrl/trimBaseUrl）和「取 origin」（urlOrigin/dropMovedKeys里的origin），合到MdgSettings.trimBaseUrl和MdgSettings.urlOrigin。两边原本都加载settings.js，行为不变。必填项检查没合并：设置页和后台的检查顺序不同，设置页还把已保存的 Key 算作已填，合并会改变用户先看到哪条报错。
验证
node scripts/selftest.mjs：39 个通过。settings.selftest.js加了结尾斜杠、空格、空值、非法地址的用例。urlOrigin改成恒返回空、去掉去斜杠，options.selftest.js和background.selftest.js的现有测试失败。