Repository navigation
侧边栏:浏览器关了扩展侧边栏时,打开失败说「当前浏览器不支持扩展侧边栏」 - #437
Merged
Merged
Conversation
Chromium 关掉侧边栏功能时 sidePanel.open 回英文的 API Unavailable,原样显示给用户(#430)。 四个入口改走 MdgErrors.openSidepanel,没有接口和接口被关说同一句话。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改了什么
浏览器关掉扩展侧边栏功能时,Chromium 的 sidePanel.open 会回英文的 API Unavailable,页面上就显示「打开侧边栏失败:API Unavailable」。现在四个入口(弹窗和播放器的 AI 总结、专注模式、摘读记录、分拣台)都改走 MdgErrors.openSidepanel:没有这个接口,或者接口被关掉,都显示「打开侧边栏失败:当前浏览器不支持扩展侧边栏」。其他错误照原样显示。
验证
没测到:手头没有真正关掉侧边栏的浏览器,API Unavailable 是模拟出来的。
关联 issue
Related to #430。只改了提示语。报告人用的是什么浏览器,还在等他回复。