Skip to content

Restrict Wine PlatformOpenURL() path to ver 8.16 - #115

Merged
zao merged 2 commits into
PathOfBuildingCommunity:masterfrom
vaisest:fix-wine-copypaste
Aug 15, 2026
Merged

Restrict Wine PlatformOpenURL() path to ver 8.16#115
zao merged 2 commits into
PathOfBuildingCommunity:masterfrom
vaisest:fix-wine-copypaste

Conversation

@vaisest

@vaisest vaisest commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Fixes #106

I tracked down the issue as it was annoying me on my Arch (btw) laptop. It seems that it was originally caused by a Wine bug, which caused a stack corruption and overflow with urls that were too long. This seems to have been fixed in Wine 8.17:

shell32: Avoid stack corruption with long name in SHELL_TryAppPathW().
shell32: Handle long command line in execute_from_key().

I could not reproduce the crash on 8.17 or my current Wine 11 versions, but I was able to reproduce it on 8.16. This successfully allows for the long-ass trade URLs to open on my laptop now. Windows also seems to work as it used to.

The solution here was to restrict the ">= 1500" branch to only Wine ver 8.16 and below.

Comment thread engine/system/win/sys_main.cpp Outdated
@zao
zao merged commit 8b05469 into PathOfBuildingCommunity:master Aug 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PlatformOpenURL's 1500-char Wine guard is far too conservative on modern Wine (measured limit: 32676), and failures are silent

2 participants