Let a read be seen on a white page, and stop a narrow column claiming a label - #55
Merged
Conversation
… a label A read body took a grey written into the code rather than one from the theme, and it measured 1.92 against a white page: a pileup a reader has to hunt for, in the theme that is the default. It measured 9.27 against a dark one, so the one colour was wrong in both directions. It is a wash of the theme's own quiet ink now, which lands at 3.21 and 4.29 and follows a theme a caller brought rather than only the two shipped here. No committed figure moves. A position label is stood on end, so what it needs across its column is its height rather than its length, and below that the labels go through each other. Fourteen hundred sites gave fourteen hundred rotated labels in a panel eight hundred pixels wide: measured on thirty samples over fourteen hundred sites, the figure carried 1,465 of them and now carries 66, which is four megabytes down to four. That change had been sitting on a branch since before the rest of this work and the branch had gone stale around it. Both are guarded by asking the question rather than by pinning the answer: one computes the contrast of whatever colour the theme gives a read, the other counts the labels a crowded panel draws.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things I knew were outstanding, both verified by running before being fixed.
A read body nobody can see
ReadColoring::Uniformfell back to#b3bcc6, a grey written into the coderather than taken from the theme. Measured:
#b3bcc6, as it wasOne colour for both themes was wrong in both directions: a pileup a reader has
to hunt for in the theme that is the default, and one shouting in the other. It
is
mix(theme.background, theme.muted, 0.65)now, which is what a large filledshape needs and follows a theme a caller brought rather than only the two shipped
here.
I had this recorded the other way round, as "the pileup ignores
--theme dark".It does not: the background and the labels follow the theme and always did. What
ignored it was the read body, and the theme it failed in was the light one.
No committed figure changes. I checked that by rendering all twenty five
examples the way CI does, not by rendering the gallery, which is what I had been
doing earlier in this session and is not the same thing.
Fourteen hundred labels through each other
A position label is stood on end, so what it needs across its column is its
height rather than its length. Below that they overlap, and they were drawn
anyway. On thirty samples over fourteen hundred sites the figure carried 1,465
rotated labels and their tooltips; it carries 66 now, and drops from 4.30 MB to
4.03 MB. It is the same threshold the letters in the cells already use.
That change had been sitting on
fix/snp-panel-densitysince before the rest ofthis work, and the branch had gone stale around it: its diff against today's main
deletes 8,872 lines, including every test added since. The change itself is
twelve lines, so it is here rather than rebased, and the branch is gone.
And one I looked at and left
The ideogram's centromere is also a colour written into the code,
#b03a2e,which measures 6.02 on white and 2.96 on the dark page. That is under the 3:1
a filled mark wants, but only just, and inside my own rounding. Moving it to
#c04a3cclears both at 4.90 and 3.64 and changes one committed figure. Changingwhat a committed figure looks like for four hundredths of a contrast point is not
mine to decide, so it is written down here rather than done.
Checks
Both guarded by asking the question rather than pinning the answer: one computes
the contrast of whatever colour the theme gives a read and fails below 3:1, which
the old grey does; the other counts the rotated labels a four hundred column
panel draws and fails at 400, which is what it drew before.