Skip to content

Fix the merge gate on main - #4909

Merged
ilidemi merged 1 commit into
mainfrom
fix-merge-gate
Oct 9, 2026
Merged

ilidemi merged 1 commit into
mainfrom
fix-merge-gate

Conversation

@ilidemi

@ilidemi ilidemi commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

GitHub matches checks by name and treats skipped as succeeded, so between internal/external job the skipped one was passing it and the flow tests weren't actually gating. Bring that back

Ex: #4908 auto-merge fired before tests finished

@ilidemi
ilidemi requested a review from a team as a code owner October 9, 2026 21:41
@ilidemi
ilidemi enabled auto-merge (squash) October 9, 2026 21:41
@claude

claude Bot commented Oct 9, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

🔄 Flaky Test Detected

Analysis: Infrastructure flake, not a test failure: all 21 tilt jobs timed out pulling the otel-collector image from Docker Hub (auth.docker.io/registry-1.docker.io "context deadline exceeded"), so ancillary services never became Ready and no tests ever ran.
Confidence: 0.97

✅ Automatically retrying the workflow

View workflow run

@ilidemi
ilidemi merged commit 139a08b into main Oct 9, 2026
46 of 68 checks passed
@ilidemi
ilidemi deleted the fix-merge-gate branch October 9, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants