Repository navigation
Add support for OIDC admin groups in addition to admin users - #6
Merged
Merged
Conversation
The chart variable is `oidc.adminGroups`, which is a list of CILogon group names. This is added to `Server.AdminGroups` in the Pelican configmap. Either `oidc.adminUsers` or `oidc.adminGroups` (or both) must be nonempty when OIDC is enabled. Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the pelican-cache Helm chart’s OIDC configuration to support granting Pelican Web UI admin privileges via CILogon group names (oidc.adminGroups) in addition to the existing per-user sub allowlist (oidc.adminUsers). It updates both the rendered Pelican configuration and the chart’s template-time validation/docs to ensure OIDC admin authorization is configured safely when OIDC is enabled.
Changes:
- Add
oidc.adminGroupstovalues.yamland render it into the Pelican config asServer.AdminGroups. - Update Helm render-time validation so that when
oidc.enabled=true, at least one ofoidc.adminUsersoroidc.adminGroupsis nonempty (and vice versa). - Update README documentation/examples and bump chart version to
0.2.4.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| values.yaml | Adds oidc.adminGroups value and documents the “users and/or groups required when enabled” rule. |
| templates/configmap-pelican.yaml | Renders oidc.adminGroups into Server.AdminGroups in config.yaml. |
| templates/_helpers.tpl | Updates validation logic to require admin users and/or groups when OIDC is enabled and to reject admin lists when OIDC is disabled. |
| README.md | Documents the new setting and provides examples for users-only, groups-only, and mixed configurations. |
| Chart.yaml | Bumps chart version from 0.2.3 to 0.2.4. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chart variable is
oidc.adminGroups, which is a list of CILogon group names.This is added to
Server.AdminGroupsin the Pelican configmap.Either
oidc.adminUsersoroidc.adminGroups(or both) must be nonempty when OIDC is enabled.