You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
…ight year
Delete GetPackages.BAT and the 3Series csproj, drop Peacock colors from VS Code settings, ignore *.code-workspace, and bump copyright to 2026.
- Update-ReadmeBadges: in -Stage mode fail when README.md or badge inputs have unstaged changes
- README: document Windows PowerShell 5.1 check command and the unstaged-changes guard
The reason will be displayed to describe this comment to others. Learn more.
Copilot review overview
🟡 Changes recommended
The hook can derive badges from uncommitted files or silently fail to stage them, and VS Code installation is not reliable with Windows PowerShell 5.1.
Handle git add failures to prevent stale badge commits
.github/scripts/Update-ReadmeBadges.ps1:109
A failed git add is a native-command failure and is not converted into a terminating PowerShell error by $ErrorActionPreference. The script can therefore report success to Husky without staging the updated README (for example, when the index is locked), allowing a stale badge commit. Check $LASTEXITCODE and fail the hook.
Pin VS Code task shell to PowerShell 7
.vscode/tasks.json:7
This folder-open task uses whichever shell VS Code selected. On Windows that may still be Windows PowerShell 5.1, where && is a syntax error, even when the required pwsh executable is installed. Pin the task shell to PowerShell 7 so the advertised automatic install works independently of the user's default terminal profile.
- Update-ReadmeBadges: include untracked badge inputs in the -Stage guard
- Update-ReadmeBadges: fail the hook when git add fails
- tasks.json: run the install task under pwsh so && works on Windows
- README: mention untracked files in the guard note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary (what/why):
Testing: not run beyond local hook install.
Notes for reviewers: 15 files changed (+223/-266); contributors need
dotnet tool restore && dotnet husky install(runs automatically via VS Code task).