Fix multiple debug messages by cdenig · Pull Request #45 · PepperDash/essentials-devtools

cdenig · 2026-09-23T16:07:40Z

This pull request introduces several improvements and fixes related to WebSocket connection handling, testing, and code quality for the application. The main focus is on making the WebSocket middleware more robust against race conditions, improving test coverage, and adding development tooling. Below are the most important changes:

WebSocket Middleware Robustness and Reliability:

Refactored websocketMiddleware to ensure only the latest WebSocket instance can dispatch actions, preventing race conditions and stale event handlers from interfering with the current connection. Added a closeSocket helper to clean up handlers before closing, and improved fallback handling logic. (src/store/websocketMiddleware.ts) [1] [2] [3] [4]
Updated the session join logic in App.tsx to prevent multiple simultaneous session requests using a useRef guard, ensuring only one join attempt is in flight at a time. (src/App.tsx)

Testing Improvements:

Added comprehensive tests for the WebSocket middleware, including connection deduplication, fallback logic, and disconnection, using a FakeWebSocket stand-in and Vitest. (src/store/websocketMiddleware.test.ts)
Updated the main app test to use Redux and React Router providers, and added a test for rendering the help page. (src/App.test.tsx)

Development Tooling:

Added eslint as a development dependency to enforce code quality. (package.json)

Repository Configuration:

Added a .gitattributes file to enforce consistent LF line endings across the repository. (.gitattributes)

Closes #44

The repository already stores all text files with LF; this keeps Windows editors and tooling from committing CRLF. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…sages Detach handlers before closing a socket and ignore events from any socket that is no longer current, so a replaced connection can't keep dispatching messages, clobber the active socket, or trigger a spurious fallback. WS_DISCONNECT now also dispatches disconnected() since the detached onclose no longer does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…nding Rapid clicks on Join started multiple debug sessions and sockets, producing duplicate console messages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

The server already returns the URL reachable from the browser's side of the network, so connect to `url` first and use `fallbackUrl` only as the fallback instead of swapping them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Referenced by .vscode/settings.json and the README; no lint config or script yet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot

Copilot review overview

🟡 Changes recommended

WebSocket connection state and session-join behavior have unresolved issues, with missing regression coverage.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 · 1

Open (2)

Test stale socket callbacks after reconnect · New
Add ESLint configuration and lint command or remove dependency · New

What changed in this PR

Improves WebSocket lifecycle handling, prevents duplicate session joins, expands tests, and adds repository tooling.

Changes:

Adds stale-socket cleanup and connection guards.
Expands middleware and app tests.
Adds ESLint dependency and LF line-ending configuration.

File	Summary
`src/store/websocketMiddleware.ts`	Hardens WebSocket lifecycle and stale-event handling.
`src/store/websocketMiddleware.test.ts`	Adds middleware connection and fallback tests.
`src/App.tsx`	Guards concurrent session joins.
`src/App.test.tsx`	Updates providers and adds help-page coverage.
`package.json`	Adds ESLint dependency.
`package-lock.json`	Locks dependency updates.
`.gitattributes`	Enforces LF line endings.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

cdenig · 2026-09-23T16:12:15Z

hey @ndorin could you please have look at this PR when you have a moment? I ran into this issue when using Debug Console testing a client mock system for Essentials v3 platform.

ndorin · 2026-09-23T17:48:04Z

@cdenig do you have a minute to address the copilot comments and then I'll review?

cdenig · 2026-09-23T17:58:02Z

Yes, I am WIP on those comments…. Got task-switched to MST for a little bit. I’ll be back to this shortly * Colin From: Neil Dorin ***@***.***> Sent: Wednesday, September 23, 2026 1:48 PM To: PepperDash/essentials-devtools ***@***.***> Cc: Colin Denig ***@***.***>; Mention ***@***.***> Subject: Re: [PepperDash/essentials-devtools] Fix multiple debug messages (PR #45) [https://avatars.githubusercontent.com/u/18535240?s=20&v=4]ndorin left a comment (PepperDash/essentials-devtools#45)<#45 (comment)> @cdenig<https://github.com/cdenig> do you have a minute to address the copilot comments and then I'll review? — Reply to this email directly, view it on GitHub<#45?email_source=notifications&email_token=AUREHQHDMZMUMMV7OKYPQIT5QQEGXA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNZZHE4TMNRVGE4KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5799966518>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AUREHQHWPCZZER6DLLYK3XT5QQEGXAVCNFSNUABFKJSXA33TNF2G64TZHM3TCMRWGIZTIMBZHNEXG43VMU5TKNJVGYYTANRRGIYKC5QC>. You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>

- eslint.config.js: @eslint/js + typescript-eslint recommended, React hooks, Vite react-refresh, plus type-aware no-floating-promises and no-misused-promises; eslint-config-prettier last to avoid conflicts - Rename prettierrc.json to .prettierrc.json so Prettier finds it, and add .prettierignore - Add lint, lint:fix, format and format:check scripts Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

No functional changes; generated by `npm run format`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

GitHub applies .git-blame-ignore-revs automatically; locally run `git config blame.ignoreRevsFile .git-blame-ignore-revs`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

- Log failures from join() instead of leaving an unhandled rejection when starting a debug session fails - Mark fire-and-forget RTK Query triggers, refetch() and navigate() with `void` (their promises don't reject without unwrap()) - Wrap async click/submit handlers so React gets a void callback - Replace `any` with `unknown` or a narrow type for the legacy monaco languages.json API; String -> string in LogMessage - Remove unused getAppIdFromPath; rename icons/index.tsx to .ts since it holds no components Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

- Drop legacy eslint.options.extensions (removed in ESLint 10), the prettier/prettier rule customization, html validation and the deprecated eslint.alwaysShowStatus; the default eslint.validate also covers .tsx, which the old list missed - Use Prettier as the default formatter and format on save - Recommend the ESLint and Prettier extensions - Document the lint and format scripts in the README Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Chore/eslint prettier config

ESLint 10, jsdom 29 and Vite 8 require Node ^20.19.0 || ^22.13.0 || >=24, so Node 18 is no longer supported. Update the README prerequisite and declare the range in package.json engines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Chore/eslint prettier config

Copilot

Copilot review overview

🟡 Changes recommended

Unresolved moderate findings remain in session guarding, stale-socket test coverage, and reconnect state handling.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 3

Open (3)

Release connection guard before WebSocket handshake completes · New
Failed reconnect leaves connection state stuck as connected · New
Test stale socket callbacks after reconnect

Resolved since last review (1)

Add ESLint configuration and lint command or remove dependency

Replace the join ref, which was released before the WebSocket opened, with an isConnecting flag in the websocket slice. It is set when a join begins and cleared when the socket opens, fails, or disconnects, and the Start button is disabled while it is set. Dispatch disconnected() when replacing a socket, since its detached onclose no longer reports it, so a failed reconnect can't leave isConnected stuck at true. Exercise the stale socket's captured handlers in the middleware tests and cover reconnect failure and the isConnecting lifecycle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot

Copilot review overview

🟡 Changes recommended

Unresolved critical stale-session handling and moderate connection-state failure findings remain.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1

Open (1)

Prevent stale session responses from connecting the wrong app · New

Resolved since last review (3)

Failed reconnect leaves connection state stuck as connected
Release connection guard before WebSocket handshake completes
Test stale socket callbacks after reconnect

Previously missed (1)

In code that hasn't changed since last review

Clear connection state when fallback connection fails

src/store/websocketSlice.ts:45

When an already-open primary socket errors, this branch closes it and tries the fallback without dispatching disconnected(). If the fallback then errors, connectionFailed only clears isConnecting, so isConnected remains true and the UI reports a connected session even though socket is gone; clear isConnected when recording a connection failure and add a regression test for this sequence.

Co-authored-by: cdenig <86131648+cdenig@users.noreply.github.com>

Copilot · 2026-09-23T19:32:43Z

Copilot review overview...

Addressed in f26a904. Stale start-session responses are now ignored after app navigation, route changes clear the active debug-session connection state, terminal websocket failures clear isConnected, and the added regressions cover both stale responses and fallback failure handling.

Copilot

Copilot review overview

🟡 Changes recommended

Critical compile/lint failures and unresolved WebSocket/session cleanup issues remain.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 2 · 3

Open (5)

Declare Node globals for Vite config linting · New
Pass the configured store type to useStore · New
Stop server debug sessions during route changes · New
Invalidate pending join requests when stopping · New
Reset connection state before fallback handshake · New

Resolved since last review (1)

Prevent stale session responses from connecting the wrong app

 function App() {
  const dispatch = useDispatch<AppDispatch>();
-  const isConnected = useSelector((state: RootState) => state.websocket.isConnected);
+  const store = useStore<RootState>();


+    }
+
+    joinRequestIdRef.current += 1;
+    dispatch({ type: WS_DISCONNECT });


    dispatch({ type: WS_DISCONNECT });
    if (!appId) return;
-    stopSession({ appId });
+    void stopSession({ appId });


+            closeSocket();
            connectToUrl(fallback);


Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

cdenig and others added 6 commits September 23, 2026 11:44

chore: enforce LF line endings via .gitattributes

1358c69

The repository already stores all text files with LF; this keeps Windows editors and tooling from committing CRLF. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

fix(console): ignore repeat Join clicks while a session request is pe…

425ee1e

…nding Rapid clicks on Join started multiple debug sessions and sockets, producing duplicate console messages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

test: replace stale CRA "learn react" test with Help route smoke test

6bb0a94

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore: add eslint as a dev dependency

fab51a0

Referenced by .vscode/settings.json and the README; no lint config or script yet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

cdenig requested review from ndorin and a lite review from Copilot September 23, 2026 16:07

cdenig self-assigned this Sep 23, 2026

Copilot started reviewing on behalf of cdenig September 23, 2026 16:08 View session

Copilot AI reviewed Sep 23, 2026

View reviewed changes

Comment thread src/store/websocketMiddleware.test.ts Outdated

Comment thread package.json

cdenig and others added 9 commits September 23, 2026 14:13

style: format codebase with Prettier

240c88c

No functional changes; generated by `npm run format`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore: ignore Prettier formatting commit in git blame

a1bcd0d

GitHub applies .git-blame-ignore-revs automatically; locally run `git config blame.ignoreRevsFile .git-blame-ignore-revs`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Merge pull request #46 from PepperDash:chore/eslint-prettier-config

bcf3a41

Chore/eslint prettier config

fix: clarify functional grouping examples in device management tutorial

e8c18ec

Merge pull request #47 from PepperDash/chore/eslint-prettier-config

9bd0cb0

Chore/eslint prettier config

cdenig requested a lite review from Copilot September 23, 2026 18:48

Copilot started reviewing on behalf of cdenig September 23, 2026 18:48 View session

Copilot AI reviewed Sep 23, 2026

View reviewed changes

Comment thread src/App.tsx Outdated

Comment thread src/store/websocketMiddleware.ts

cdenig requested a lite review from Copilot September 23, 2026 19:17

Copilot started reviewing on behalf of cdenig September 23, 2026 19:18 View session

Copilot AI reviewed Sep 23, 2026

View reviewed changes

Comment thread src/App.tsx

Copilot started work on behalf of cdenig September 23, 2026 19:28 View session

fix stale debug session state on app changes

f26a904

Co-authored-by: cdenig <86131648+cdenig@users.noreply.github.com>

Copilot finished work on behalf of cdenig September 23, 2026 19:34

cdenig requested a lite review from Copilot September 23, 2026 19:35

Copilot started reviewing on behalf of cdenig September 23, 2026 19:36 View session

Copilot AI reviewed Sep 23, 2026

View reviewed changes

fix: Merge browser and node globals in ESLint config

be5edca

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Navigation Menu

Fix multiple debug messages - #45

Fix multiple debug messages#45
cdenig wants to merge 18 commits into
feature/add-inline-helpfrom
fix-multiple-debug-messages

cdenig commented Sep 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

cdenig commented Sep 23, 2026

Uh oh!

ndorin commented Sep 23, 2026

Uh oh!

cdenig commented Sep 23, 2026 via email

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI commented Sep 23, 2026

Copilot review overview...

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

cdenig commented Sep 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

cdenig commented Sep 23, 2026

Uh oh!

ndorin commented Sep 23, 2026

Uh oh!

cdenig commented Sep 23, 2026 via email

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI commented Sep 23, 2026

Copilot review overview...

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants