Chore/eslint prettier config - #47
Merged
cdenig merged 2 commits intoSep 23, 2026
Merged
Conversation
ESLint 10, jsdom 29 and Vite 8 require Node ^20.19.0 || ^22.13.0 || >=24, so Node 18 is no longer supported. Update the README prerequisite and declare the range in package.json engines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review comments remain.
Review effort: Lite
Findings: None
What changed in this PR
Updates Node.js requirements and clarifies device naming documentation.
Changes:
- Adds supported Node.js engine constraints.
- Updates README prerequisites and lockfile metadata.
- Improves wildcard naming examples.
| File | Description |
|---|---|
README.md |
Documents supported Node.js versions. |
package.json |
Adds Node.js engine constraints. |
package-lock.json |
Synchronizes lockfile metadata. |
docs/tutorials/device-management-basics.md |
Clarifies naming examples. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates documentation and configuration to require newer Node.js versions and clarifies device naming examples. The most important changes are:
Node.js version requirements:
README.mdto require Node.js 20.19+, 22.13+, or 24+ (instead of just 18+), reflecting the needs of Vite, Vitest, and ESLint.enginesfield topackage.jsonspecifying the supported Node.js versions (^20.19.0 || ^22.13.0 || >=24).Documentation improvements:
docs/tutorials/device-management-basics.mdby using code formatting and wildcards for functional grouping (Boardroom-*,Training-*).