Conversation
|
🎉 This PR is included in version 1.25.0-fix-cache-busting-http-calls-v3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The public initialization Axios client still lacks cache busting, so not all processor HTTP calls are covered.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Adds cache-busting query parameters to processor HTTP requests through the WebSocket middleware client.
Changes:
- Appends unique
_timestamp/random query parameters. - Leaves WebSocket traffic unchanged.
- Does not update the separate public initialization client.
| File | Summary |
|---|---|
src/lib/store/middleware/websocketMiddleware.ts |
Adds cache busting to middleware HTTP requests; the public initialization client remains uncovered. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the cache-busting fix (
58c2244) onto thefeat/essentials-v3line (basev1.25.0-feat-essentials-v3.27).Companion to #107 (same fix into
main) and the Essentials PRs #1484 / #1485.Why
Newer Crestron CH5 runtimes (1.3.0.x, pulled onto DGE panels via auto-update) enabled an aggressive caching mode that serves stale responses for the app's HTTP calls to the processor — including
joinroom— leaving panels stuck in a 1008 reconnect loop / half-loaded UI. Root-caused with A. Welker at KPMG, validated in the NYC lab, confirmed live at The New Yorker.What
Adds an axios request interceptor on the library's
httpClientthat appends a unique query param (_=<base36 timestamp><base36 random>) to every request, so each URL is unique and bypasses the cache. Ignored by the MC server; WebSocket untouched.Cherry-picked cleanly from
58c2244; builds clean (ES + UMD + type declarations).