Repository navigation
Evaluate PDF and phone lookup against existing IDs and simple aliases - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainers asked whether another identifier improves an already working lookup. Add a local comparison form with existing invoice numbers/hostnames, a five-character alias and RefMint on the same synthetic records. Include a downloadable PDF whose actual extracted identifiers are replayed through the lookup model.
Record all 54 selected fixture outcomes, printed lengths and logical lookup counts, including advantages of existing identifiers and short aliases. Demonstrate checksum rejection, partial-search ambiguity, equal access scope and a different complete valid code still selecting another record. No production support data, human-entry improvement or upstream integration is claimed. Enrollment/credentials are outside the example; original invoice strings and leading zeros remain intact.
Document when RefMint is unnecessary and distinguish npm availability, alpha API status, the frozen existing-ID v1 contract and authorization. Runtime code, public API, wire format and runtime dependencies are unchanged; no release is published.
Validation: 39 Node tests, type checks, 54 workflow fixtures, existing Bech32m comparison (28 cases and 1,576 mutations per adapter), offline package installation, two HTTP tests, and seven Chromium tests pass locally. The one-page PDF was regenerated, extracted, replayed and visually inspected. CI also verifies the PDF, five Node/OS combinations, Firefox and WebKit.