Skip to content

ci(cli): comment test coverage on pull requests - #404

Merged
0x76agabond merged 3 commits into
Perfect-Abstractions:mainfrom
0x76agabond:ci/cli-coverage-comment
Oct 3, 2026
Merged

0x76agabond merged 3 commits into
Perfect-Abstractions:mainfrom
0x76agabond:ci/cli-coverage-comment

Conversation

@0x76agabond

Copy link
Copy Markdown
Collaborator

Summary

Add a CLI coverage report comment to pull requests.

Changes Made

  • Run CLI tests with coverage and upload the report as a CI artifact.
  • Post or update one coverage comment per PR.
  • Add tests for report generation and comment handling.

Checklist

Before submitting this PR, please ensure:

  • Code follows the Solidity feature ban - No inheritance, constructors, modifiers, public/private variables, external library functions, using for directives, or selfdestruct

  • Code follows Design Principles - Readable, uses diamond storage, favors composition over inheritance

  • Code matches the codebase style - Consistent formatting, documentation, and patterns (e.g. ERC20Facet.sol)

  • Code is formatted with forge fmt

  • Existing tests pass - Run tests to be sure existing tests pass.

  • New tests are optional - If you don't provide tests for new functionality or changes then please create a new issue so this can be assigned to someone.

  • All tests pass - Run forge test and ensure everything works

  • Documentation updated - If applicable, update relevant documentation

  • Changesets — If this PR changes publishable packages (src/, cli/), changeset-bot will comment if a release note might be needed. You can add one when convenient or defer to maintainers.

Make sure to follow the contributing guidelines.

Additional Notes

@netlify

netlify Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

👷 Deploy request for compose-diamonds pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5b20797

@changeset-bot

changeset-bot Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5b20797

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@perfect-abstractions/compose-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@0x76agabond
0x76agabond merged commit 96a4daf into Perfect-Abstractions:main Oct 3, 2026
5 checks passed
@0x76agabond
0x76agabond deleted the ci/cli-coverage-comment branch October 3, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant