Repository navigation
Conversation
👷 Deploy request for compose-diamonds pending review.Visit the deploys page to approve it
|
🦋 Changeset detectedLatest commit: 140bf88 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
CLI CoverageCommit:
|
maxnorm
changed the title
Collaborator
|
Hey @maxnorm, I like how you structured this. Keeping facet configuration separate from deployment makes sense. Should we add a warning when removing a required facet from the selected preset? Removal can remain allowed, but users should know the resulting composition may no longer implement the full standard. |
Copy locally imported facet dependencies into the same relative folder structure they have under their facet's source directory, so relative imports such as ./libraries/LibFee.sol keep resolving after install. Applies the shared planImportClosureTargets helper to both the install pipeline and init scaffolding.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add facet configuration commands ahead of deployment: compose install / i registers facets; compose remove / rm unregisters them. Both update compose.json only.
Changes Made
Checklist
Before submitting this PR, please ensure:
Code follows the Solidity feature ban - No inheritance, constructors, modifiers, public/private variables, external library functions,
using fordirectives, orselfdestructCode follows Design Principles - Readable, uses diamond storage, favors composition over inheritance
Code matches the codebase style - Consistent formatting, documentation, and patterns (e.g. ERC20Facet.sol)
Code is formatted with
forge fmtExisting tests pass - Run tests to be sure existing tests pass.
New tests are optional - If you don't provide tests for new functionality or changes then please create a new issue so this can be assigned to someone.
All tests pass - Run
forge testand ensure everything worksDocumentation updated - If applicable, update relevant documentation
Changesets — If this PR changes publishable packages (
src/,cli/), changeset-bot will comment if a release note might be needed. You can add one when convenient or defer to maintainers.Make sure to follow the contributing guidelines.
Additional Notes
Generated deployment scripts remain snapshots from init; deployment-flow work will need consume the updated compose.json for the new deployment script generation