Skip to content

fix(cli): defer build freshness to framework compiler - #417

Merged
maxnorm merged 2 commits into
Perfect-Abstractions:mainfrom
maxnorm:fix/compile-build-freshness
Oct 14, 2026
Merged

maxnorm merged 2 commits into
Perfect-Abstractions:mainfrom
maxnorm:fix/compile-build-freshness

Conversation

@maxnorm

@maxnorm maxnorm commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Always invoke the framework compiler from compose build and let Foundry or Hardhat evaluate its incremental build graph.
  • Remove the CLI mtime heuristic that missed deleted sources, config changes, and package Solidity sources.
  • Add a test that verifies build delegates to the framework compiler.

Tests

  • Focused compile module test passes (1 test).
  • Lint not run: ESLint is not installed in this worktree.

@netlify

netlify Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

👷 Deploy request for compose-diamonds pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 0ffed76

@changeset-bot

changeset-bot Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0ffed76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@perfect-abstractions/compose-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

CLI Coverage

Commit: 0ffed76

Metric Coverage Covered/Total
Lines 72% 2106/2940
Functions 74% 439/592
Branches 62% 1195/1939

@maxnorm
maxnorm merged commit 7202da5 into Perfect-Abstractions:main Oct 14, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant