perf: share boxed closure capture layouts by function - #11177
Closed
proggeramlug wants to merge 2 commits into
Closed
proggeramlug wants to merge 2 commits into
proggeramlug wants to merge 2 commits into
Conversation
|
Warning Review limit reachedNext included review available in 55 seconds. View limit detailsLimit details: You’ve used all 8 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (17)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Merge queue: neither red on this run is yours.
No action needed unless the re-run fails again. If you're about to push anyway, that also clears the custody failure. |
This was referenced Sep 27, 2026
Merged
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closure creation currently stores a per-instance list of boxed capture slots and repeats lifetime bookkeeping for every slot. This change emits a constant bitmap for each compiled function and registers all its boxed captures in one call. Runtime instances retain only a weak owner address; marking, cloning, relocation and death pruning read the cells from the closure payload.
Per-box reference counts remain necessary for frame/async release. The old setter remains available for dynamic runtime callers, with a fallback to exact edges when a shared-layout closure is modified. Fresh boxed closures also use the existing bulk capture initializer.
Validation:
No version bump. This removes the per-closure edge-list allocation/storage on generated paths; no end-to-end performance percentage is claimed.