Use shape-proven F64 facts in guarded loop regions - #11708
Closed
proggeramlug wants to merge 6 commits into
Closed
proggeramlug wants to merge 6 commits into
proggeramlug wants to merge 6 commits into
Conversation
added 5 commits
September 30, 2026 10:43
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 30, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Numeric object fields proven by a ShapeId now remain native doubles throughout a guarded loop region. Before this change, reads entered the region fast clone but boxed into generic arithmetic for receiver shapes learned at runtime; the same four-read matrix cells cost 44 or 92–94 instructions per iteration. Afterward they cost 19 or 49–50, with Node-equivalent output and unchanged overwrite controls.
Changes
Related issue
n/a — step 5 P7 of the one-shape object-model campaign.
Test plan
3699de102886963c8267d5b572d654232caea26a; final PR headd7f5e014d9618f05e49b79e2f8d4d9ce82adaa99adds only the changelog.rloop_f_rep=200000; emitted fast IR has nativeload doubleandfadd double.Checklist