Skip to content

ci: bound the non-gating statepoints hazard census - #11742

Merged
proggeramlug merged 2 commits into
mainfrom
codex/ci-bound-statepoints-census-20261002
Oct 2, 2026
Merged

proggeramlug merged 2 commits into
mainfrom
codex/ci-bound-statepoints-census-20261002

Conversation

@proggeramlug

@proggeramlug proggeramlug commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

The statepoints job can finish every required check and then be cancelled by its non-gating hazard census. In #11735 job 110544421021, required work finished at 20:57 UTC after roughly 79 minutes; the census ran until the whole 90-minute job was cancelled at 21:08 UTC.

Give the existing diagnostic step a five-minute timeout so it leaves time for job completion. Its existing explicit continue-on-error remains in place. Required curated and dependency-scale root checks, corpus floors, failure thresholds and checker commands are unchanged.

Validation: gate-wiring self-test (18 cases), gate-wiring audit (9 gates) and whitespace checks pass. Full local script lint at final head 224c4ec completed: 110 of 111 checks passed; only the grandfathered Public benchmark evidence freshness check failed. Compile-tier commands and two CI-only commands were explicitly skipped. Actual current-head workflow CI is terminal, with only that same lint step and its pr-gate fan-in failing; all other executed checks passed. Required root-check commands and gating rules are byte-unchanged. This does not waive a cancelled whole GC job: #11735's exact-head statepoints rerun 110684548790 has independently completed successfully. The new diagnostic timeout itself has not yet been exercised by a timed-out full GC job.

Summary by CodeRabbit

  • Chores
    • Limited the diagnostic hazard census to five minutes. Required checks and failure thresholds are unchanged.

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 29678cad-bc81-4b7f-9738-888488dba914

📥 Commits

Reviewing files that changed from the base of the PR and between 47a0c7b and 224c4ec.

📒 Files selected for processing (2)
  • .github/workflows/gc-root-dominance.yml
  • changelog.d/11742-bounded-statepoints-census.md

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

The workflow now limits the unfiltered hazard census step to five minutes. Its existing failure-tolerance settings remain unchanged. A changelog entry documents the limit and states that required checker coverage and failure thresholds remain unchanged.

Changes

Statepoints hazard census

Layer / File(s) Summary
Bound and document the census
.github/workflows/gc-root-dominance.yml, changelog.d/11742-bounded-statepoints-census.md
The workflow adds a five-minute timeout to the unfiltered hazard census step. The changelog records the timeout and notes that required checker coverage and failure thresholds remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 224c4

The five-minute limit affects only optional diagnostics and does not change production behavior or required checks. No PR-introduced merge risk was found; CI remains non-green because of the separate benchmark-freshness failure.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the CI change: adding a bound to the non-gating statepoints hazard census.
Description check ✅ Passed The description clearly explains the problem, the five-minute timeout, preserved gating behavior, affected checks, and validation results. It does not follow the template headings and does not explici…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proggeramlug
proggeramlug marked this pull request as ready for review October 2, 2026 04:25
@proggeramlug
proggeramlug merged commit a97f96e into main Oct 2, 2026
53 of 55 checks passed
@proggeramlug
proggeramlug deleted the codex/ci-bound-statepoints-census-20261002 branch October 2, 2026 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant