ci: bound the non-gating statepoints hazard census - #11742
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe workflow now limits the unfiltered hazard census step to five minutes. Its existing failure-tolerance settings remain unchanged. A changelog entry documents the limit and states that required checker coverage and failure thresholds remain unchanged. ChangesStatepoints hazard census
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The five-minute limit affects only optional diagnostics and does not change production behavior or required checks. No PR-introduced merge risk was found; CI remains non-green because of the separate benchmark-freshness failure. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The statepoints job can finish every required check and then be cancelled by its non-gating hazard census. In #11735 job 110544421021, required work finished at 20:57 UTC after roughly 79 minutes; the census ran until the whole 90-minute job was cancelled at 21:08 UTC.
Give the existing diagnostic step a five-minute timeout so it leaves time for job completion. Its existing explicit continue-on-error remains in place. Required curated and dependency-scale root checks, corpus floors, failure thresholds and checker commands are unchanged.
Validation: gate-wiring self-test (18 cases), gate-wiring audit (9 gates) and whitespace checks pass. Full local script lint at final head 224c4ec completed: 110 of 111 checks passed; only the grandfathered Public benchmark evidence freshness check failed. Compile-tier commands and two CI-only commands were explicitly skipped. Actual current-head workflow CI is terminal, with only that same lint step and its pr-gate fan-in failing; all other executed checks passed. Required root-check commands and gating rules are byte-unchanged. This does not waive a cancelled whole GC job: #11735's exact-head statepoints rerun 110684548790 has independently completed successfully. The new diagnostic timeout itself has not yet been exercised by a timed-out full GC job.
Summary by CodeRabbit