fix(async_hooks): defer destroy until execution scopes finish - #11761
Draft
proggeramlug wants to merge 5 commits into
Draft
proggeramlug wants to merge 5 commits into
proggeramlug wants to merge 5 commits into
Conversation
…nc-destroy-order-20261002
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A timer callback checkpoint can drain queued destroy hooks before the enclosing async scope emits its
afterhook. Defer queue draining while the execution stack is nonempty, preserving queued resources until the next outer checkpoint. The regression checks nested scopes, retained queued resources and exactly one final drain. The old implementation fails the new unit with drain count 2 versus expected 0; the fixed eight-unit suite passes.Current head is
00ad2a4f20224df7083ce8173852c6d90fd2940f, including main7443a2b088564dfcbfa85dc82b9e97e26d9a0c2fand the PR-keyed changeset. Final-head Linux validation uses nightly 2026-08-20, LLVM 22.1.8 and pinned Node 26.5.1:issue_6764_async_hooks_lifecycleintegration passed.Both current-head whole GC jobs succeeded: shadow root dominance and native statepoints root dominance. The earlier cancelled/skipped run is not used for approval.
Two earlier failed attempts remain recorded: the initial lint attempt lacked cargo-xwin, then passed after installing the pinned tool; a separate original-getter diagnostic reproduced the builtin-class-ID assertion
0xffff0024. Its combined runner reports failure despite both full-suite phases passing. That getter problem is repaired separately by #11766; this PR does not claim to fix it or that its failed diagnostic passed.Draft pending final product coherence and hosted PR acceptance. The test-routing and shard-budget repairs in #11756 are relevant to the remaining queue CI. No overall CI or merge approval is claimed.