fix(ci): repair native-root provider bootstrap and Windows probe - #11762
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe workflow now runs the Windows try/catch probe with GC diagnostics and checks its evacuation-liveness and statepoint reports. The stdlib provider fixture adds Darwin framework links and retains and exports feature-installation entry points. ChangesWindows GC probe
macOS stdlib provider
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to No concrete issue currently blocks merging; complete the required aggregate checks before merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…cos-provider-frameworks-20261002
The native-root workflow had two fixture failures: Windows probe 09 expected the old WinEH funclet refusal even though the compiler now correctly avoids that path, and the macOS stdlib provider omitted required frameworks and generated bootstrap exports.
Update the Windows probe to check current compiler behavior, Node parity and positive moving-GC evidence while retaining the real compiler unit that rejects funclet modules before RS4GC. Link the Darwin provider with CoreFoundation/Foundation, retain the typed
js_stdlib_install_compiledandjs_stdlib_register_feature_installerfunctions, and add both to its explicit export list. No production Rust, external ABI or GC root-store behavior changes.At final head
5a779d7c477f7e70318475f2fe0c8b1c36b9b6c3:linker::tests::rs4gc_refuses_wineh_funclet_modules_before_the_pass_runstest ran and passed.Current native dispatch 37004772458 has successful whole Linux, ARM Linux, Windows and macOS jobs at this exact head. The Windows provider-dylib step is skipped as platform-inapplicable; its native-root probes pass. The Linux/ARM/macOS provider-boundary steps pass. The native aggregate and whole native workflow also completed successfully. Required PR-tier acceptance remains pending; this is not overall CI approval.
Earlier head
e6f5b7eb36d435ee8ba5dae9a443d14ac209e537fixed framework linking and passed the runtime-only provider GC witness, then failed Response application loading on_js_stdlib_install_compiled. That failure prompted the two bootstrap pins/exports above and remains recorded; it is not waived.This combines the original Windows repair #11755. Keep that PR open until this replacement is verified merged. Local validation and all four native-platform jobs are complete. Ready for review; hosted PR acceptance remains required before merging.