fix(ci): route immutable thread-global codegen tests - #11767
Closed
proggeramlug wants to merge 2 commits into
Closed
proggeramlug wants to merge 2 commits into
proggeramlug wants to merge 2 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Superseded: thread_immutable_globals is already mapped in scripts/ci_e2e_scope.py on main (#11768). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrated into draft #11756 at
79affe7b50bb109ce3f1d69e2754d7faebc5be72, alongside the gap-shard timeout repairs. Keep this PR open until the combined replacement is verified merged. Neither PR is currently merge-approved; final compiler/product/lint and hosted acceptance remain pending.The
e2e-scopedjob rejects every core PR after #11734 addedthread_immutable_globalswithout registering it in the codegen source-to-suite map. Register the existing three-test, in-process IR suite so it runs for codegen source changes.Validation: the current-main planner self-test reproduces the unclassified-suite failure; the repaired self-test passes. Routing controls confirm direct suite selection, preserved existing mapped suites, the 300-second mapped timeout, coverage with
--cap 1, and unchanged unrelated HIR scope. No suite is excluded.Draft pending final compiler product/lint validation and hosted CI. This changes only test routing; the existing Rust suite and production code are unchanged.