fix(gc): root the raw handles #11815/#11843 added - #11861
Merged
Merged
Conversation
added 2 commits
October 4, 2026 02:22
…ck to baseline for these files)
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (6)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings raw_handle_debt back to its baseline for the three files #11815 and #11843 touched (901 → 893; the remaining 22 sites are in promise/then.rs and node_stream_readwrite.rs).
Every pointer is now consumed inside its with_mut_ptr closure by a non-allocating operation, or by one that roots its receiver before allocating. Two raw-pointer returns became handle/NaN-box returns:
prototype_from_templatereturnsOption<RuntimeHandle>in the caller's scope, andmint_birth_recordreturns the boxed value. No behaviour change.Runtime tests 4837/0 (--test-threads=1); the prototype-in-shape and 11759 gap tests match node.