Repository navigation
Begin removal of analysisUtils - #402
Open
thomaswilliamsastro wants to merge 1 commit into
Open
thomaswilliamsastro wants to merge 1 commit into
thomaswilliamsastro wants to merge 1 commit into
Conversation
Collaborator
Author
|
@e-koch I'm sorry about this |
thomaswilliamsastro
force-pushed
the
au-removal
branch
from
September 24, 2026 09:08
ca392ae to
2546360
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #402 +/- ##
=========================================
- Coverage 7.96% 7.89% -0.07%
=========================================
Files 42 42
Lines 16615 16794 +179
Branches 3978 3996 +18
=========================================
+ Hits 1323 1326 +3
- Misses 15269 15445 +176
Partials 23 23
|
thomaswilliamsastro
force-pushed
the
au-removal
branch
5 times, most recently
from
October 1, 2026 16:03
84eae6d to
a9132d1
Compare
thomaswilliamsastro
force-pushed
the
au-removal
branch
2 times, most recently
from
October 5, 2026 14:29
eac9623 to
39d9aaa
Compare
This PR starts the long-overdue removal of the analysisUtils dependency. Keeping this up-to-date is difficult, complicates tests, and makes keeping the pipeline transferable annoying. This first step removes the analysisUtils dependencies for everything except the SD pipeline. The reason the SD pipeline has been left out is because there are *a lot* of functions here that would need to be translated, both across the current version and the legacy pipeline. There's a decision to be made here about whether now is the time to deprecate the legacy pipeline; I think it is, but happy to hear opinions. In any case, the shared functions have been moved into utilsSingleDish, so it'll be super easy to rip it out in the future. Major change summary: - Removed the calls to au.createCasaTool(). Since we now use a unified CASA version, this is no longer needed. - Add a new custom estimate_synthesised_beam function. This has modifications to be better for large datasets by optionally using the first field in the dataset, and will loop over each observation ID to find a minimum beam size from each individual, concatenated observation. It's about twice as fast, and is quieter. - Add a new custom pick_cell_size function. This is a little different from the au equivalent. First, it'll always return the image size, and automatically pads for an FFT (we were actually doing this twice, in effect, so now the image sizes should be smaller). Second, it does not take in information about the target or the SPW, since we only ever call this at a point where we've already split out the dataset to a single target and window. - Add get_spw_info function, which is essentially a direct translation of the analysisUtils function, with a bit of tidying up - Add get_scans_for_spw function, which is essentially a direct translation of the analysisUtils function, with a bit of tidying up - Add get_science_spws function, which is essentially a direct translation of the analysisUtils function, with a bit of tidying up - Add get_chan_widths function, which is essentially a direct translation of the analysisUtils function, with a bit of tidying up - Add clear_pointing_table function, which is essentially a direct translation of the analysisUtils function, with a bit of tidying up - A couple of functions, get_sourcename and read_source_coordinates, have been moved from to casaLegacySingleDishRoutines to utilsSingleDish - Updated tests to remove those no longer needed Detailed changes: - Remove au.createCasaTool calls from casaCubeRoutines - Remove au.createCasaTool calls from casaFeatherRoutines - Remove au.createCasaTool calls from casaImagingRoutines - Replaced au.pickCellSize with pick_cell_and_im_size in casaImagingRoutines - Replaced au.ValueMapping call with get_spw_info in casaImagingRoutines - Remove au.createCasaTool calls from casaLegacySingleDishRoutines - Move get_sourcename and read_source_coordinates from casaLegacySingleDishRoutines to utilsSingleDish - Remove au.createCasaTool calls from casaMaskingRoutines - Remove au.createCasaTool calls from casaMosaicRoutines - Remove unused analysisUtils import from casaRoutineTests - Update imports for get_sourcename and read_source_coordinates in casaSingleDishALMAWrapper - Remove au.createCasaTool calls from casaVisRoutines - Add estimate_synthesised_beam function to casaVisRoutines - Add pick_cell_and_im_size function to casaVisRoutines - Add get_representative_freq function to casaVisRoutines - Add get_obs_ids function to casaVisRoutines - Add get_chan_widths function to casaVisRoutines - Add get_spw_info function to casaVisRoutines - Add get_scans_for_spw function to casaVisRoutines - Add get_science_spws function to casaVisRoutines - Add get_observatory_name function to casaVisRoutines - Add clear_pointing_table function to casaVisRoutines - Replace estimateSynthesizedBeam in clean_call - Remove unused analysisUtils import from handlerImaging - Remove au.createCasaTool calls from handlerImagingChunked - Remove au.createCasaTool calls from handlerTestImaging - Remove au.createCasaTool calls from utilsFieldSelection - Replaced getScienceSpws in utilsFieldSelection - Remove au.createCasaTool calls from utilsSingleDish - Remove au.createCasaTool calls from utilsTestImagingPlots - Update tests - Update CHANGELOG.md
thomaswilliamsastro
force-pushed
the
au-removal
branch
from
October 7, 2026 07:08
39d9aaa to
a46cd79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR starts the long-overdue removal of the analysisUtils dependency. Keeping this up-to-date is difficult, complicates tests, and makes keeping the pipeline transferable annoying. This first step removes the analysisUtils dependencies for everything except the SD pipeline.
The reason the SD pipeline has been left out is because there are a lot of functions here that would need to be translated, both across the current version and the legacy pipeline. There's a decision to be made here about whether now is the time to deprecate the legacy pipeline; I think it is, but happy to hear opinions.
In any case, the shared functions have been moved into utilsSingleDish, so it'll be super easy to rip it out in the future.
Major change summary:
Detailed changes: