Repository navigation
Bug fixes to make the legacy SD pipeline work again - #410
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The CASA-dependent legacy workflow cannot be reliably validated in the available environment.
Review effort: Balanced
Findings: None
What changed in this PR
Restores compatibility with the legacy single-dish pipeline.
Changes:
- Normalizes TP directory paths.
- Corrects legacy velocity ranges, keyword names, and frequency units.
- Removes redundant per-dataset invocation.
| File | Description |
|---|---|
phangsPipeline/handlerSingleDish.py |
Fixes legacy pipeline argument construction and execution. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #410 +/- ##
======================================
Coverage 7.96% 7.96%
======================================
Files 42 42
Lines 16618 16615 -3
Branches 3980 3978 -2
======================================
Hits 1323 1323
+ Misses 15272 15269 -3
Partials 23 23
|
Swap vel_cube vs vel_line and fix key errors Be robust to trailing slashs in the MS key file
thomaswilliamsastro
force-pushed
the
js_dev
branch
from
October 7, 2026 07:01
5135cc2 to
1e00523
Compare
thomaswilliamsastro
approved these changes
Oct 7, 2026
Collaborator
|
Looks good. I'm not quite sure what this does for multi-MS SD data, but happy to accept this as an unfixed (for now) edge case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are needed so I could run the legacy SD pipeline on a TP dataset from the MAUVE-ALMA program.
task_execute_single_dish_pipelinecallvel_cubevsvel_linefor the legacy pipeline (the nomenclature is reversed there)