Skip to content

Backport JTC tracking and release Controls 1.0.0 - #8

Merged
mrgh97 merged 4 commits into
stable/1.xfrom
codex/release-forge1
Nov 18, 2026
Merged

mrgh97 merged 4 commits into
stable/1.xfrom
codex/release-forge1

Conversation

@mrgh97

@mrgh97 mrgh97 commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Backport #4 and the stall-window regression fix to Forge 1. Keep Dora 0.4.1. Update Forge Msgs to 1.3.1 within the 1.x line so the lock can use the audited Pillow 13.0.0. Prepare stable/1.x to publish v1.0.0.

…g lag

The controller compared the planned and measured joint positions on every tick
and aborted as soon as one joint exceeded `path_position_tolerance` (0.15 rad).
That threshold silently encodes the plant's tracking capability, so a motion
planned without knowledge of the specific plant (MuJoCo model vs. a real arm
with different servo bandwidth) fails mid-motion even when the target is
reachable, and any change of plant requires retuning the controller.

Plant capability is not the controller's contract. This change keeps the
controller as the trajectory player and moves capability decisions out of it:

* the per-tick `path_position_tolerance` abort is removed; the field is kept
  for YAML compatibility and documented as deprecated/unused;
* a hard abort remains for a real tracking failure: any joint deviating more
  than `path_abort_tolerance` (default 0.5 rad) aborts the goal, and the message
  now names the offending joint with planned and measured values (observability
  the previous message lacked);
* a stall detector aborts when the reference moved at least
  `stuck_reference_epsilon` (0.05 rad) within `stuck_window_ms` (1000 ms) while
  the measured position moved less than `stuck_actual_epsilon` (0.02 rad),
  which catches a blocked joint instead of letting it push for the whole
  trajectory;
* the terminal goal judgement (SETTLING, goal_position/goal_velocity/
  goal_time tolerance) is unchanged, so "did it arrive?" is still verified.

Legacy YAML that declares a soft band above 0.5 rad keeps working: the hard
band defaults to max(0.5, path_position_tolerance).

Tests: the former path-tolerance abort test is replaced by one asserting that a
small lag no longer aborts, plus new cases for the hard deviation (message names
the joint) and the stall detector. 23 tests pass for the package.
Aborting is only half of a failure story: the caller needs to know the arm is
not left drifting. The controller already keeps commanding the position measured
at the abort on every later tick (state `HOLDING`, no decel ramp, no retry), but
that contract was undocumented and untested.

* add `test_abort_keeps_commanding_the_measured_position`, which aborts a goal
  and then asserts ten consecutive ticks re-emit the same position-mode command;
* document the abort/hold behavior in the package README.
@mrgh97
mrgh97 merged commit b985a46 into stable/1.x Nov 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant