Repository navigation
Backport joint-state query and release Sim Control Policy 1.0.0 - #12
Merged
Merged
Conversation
…k the pose The endpoint only offered `get_robot_info` (static descriptor) and `reset`. A caller that aborts a motion, or that wants to verify where the arm actually is, had no way to read the measured joint state -- the simulator publishes `JointState` on `mujoco/proprio_state`, but nothing in this node subscribed to it, so failures were only diagnosable by inferring from the next motion. * new `joint_state` dora input caches the newest `JointState` (`state.py`, `JointStateCache`) with its arrival timestamp; * new `sim.control/get_joint_state` **query** operation returns `name`, `position`, `velocity`, `effort` and `age_ms`; * the query fails with `NO_FRESH_ROBOT_STATE` when no sample arrived or the newest is older than `joint_state_timeout_ms` (new config key, default 200 ms, matching the 50 Hz publish rate), so a stale pose is never reported as current; * `TOOL_CONTRACTS.md` / `README.md` document the new operation and dora port. Tests: cache freshness (fresh, stale, empty), the query through the endpoint, the same query through the dora binding, the `joint_state` input path, and config parsing. 74 tests pass for the package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #8 and its Ruff fixes to Forge 1, keeping the Forge 1 ToolMessage transport. Keep Dora 0.4.1. Update Forge Msgs to 1.3.1 within the 1.x line so the lock can use the audited Pillow 13.0.0. Prepare stable/1.x to publish v1.0.0.