Skip to content

Filter inactive gists, key-less Soroban reads, drop dead cache, scope winston lint rule - #1516

Merged
BigBen-7 merged 1 commit into
PinSpace-Org:mainfrom
LGTM-ButItsBroken:lgtm/issues-1405-1408
Oct 15, 2026
Merged

BigBen-7 merged 1 commit into
PinSpace-Org:mainfrom
LGTM-ButItsBroken:lgtm/issues-1405-1408

Conversation

@LGTM-ButItsBroken

Copy link
Copy Markdown
Contributor

Closes #1405
Closes #1406
Closes #1407
Closes #1408

  • winston.config.ts: kept import = require (the project has no esModuleInterop, and enabling it would change every import * as of a callable CJS module) with a narrowly scoped eslint-disable and an explanatory comment
  • gists.service.ts: removed the dead CacheEntry, contentCache and CACHE_TTL_MS
  • gist.repository.ts: findNearby, findByGistId, countNearby and countNearbyByCell now require is_active = true; findByStellarGistId is left as is since the indexer uses it. Added integration tests that flip is_active and assert the gist disappears
  • soroban.service.ts: the four live reads (getGistLive, isActiveLive, listGistsByCellLive, getAdminLive) take their simulation source from a new optional SOROBAN_READ_ACCOUNT (validated as a Stellar public key), falling back to the signer; they no longer need STELLAR_SECRET_KEY

.env.example is not touched here to avoid conflicting with the env-doc PR; SOROBAN_READ_ACCOUNT is validated in env.validation.ts. Tests and build were not run.

@drips-wave

drips-wave Bot commented Oct 15, 2026

Copy link
Copy Markdown

@LGTM-ButItsBroken Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@BigBen-7
BigBen-7 merged commit d56f650 into PinSpace-Org:main Oct 15, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants