Skip to content

[Movement] Prevent gravity from introducing lift-induced drag - #252

Merged
tryuan99 merged 1 commit into
masterfrom
titan/gravity_induced_drag
Oct 8, 2026
Merged

tryuan99 merged 1 commit into
masterfrom
titan/gravity_induced_drag

Conversation

@tryuan99

@tryuan99 tryuan99 commented Oct 6, 2026

Copy link
Copy Markdown
Member

Gravity should not introduce lift-induced drag. However, level flight does introduce lift-induced drag because of the needed lift to counter gravity.

@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: PisterLab/micromissiles-unity/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 8b251ba3-7416-40b6-b20d-42cb0e525593
📥 Commits

Reviewing files that changed from the base of the PR and between 74c496e and dc3a95b.

📒 Files selected for processing (2)
  • Assets/Scripts/Movements/MissileMovement.cs
  • Assets/Tests/EditMode/MissileMovementTests.cs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

CalculateNetAccelerationInput now calculates lift-induced drag from the supplied acceleration input without gravity. Gravity remains in the returned net acceleration. Ready, Boost, and Midcourse tests now expect no lift-induced drag when lift input is absent. Ready and Midcourse expect zero longitudinal acceleration; Boost expects boost acceleration alone.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to dc3a9

The change separates gravity from induced-drag input while retaining drag from explicit normal input. No actionable merge risk is established by the available evidence.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 10.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the change: preventing gravity from introducing lift-induced drag.
Description check ✅ Passed The description explains how gravity and lift relate to lift-induced drag, which matches the changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tryuan99
tryuan99 merged commit cb36c1a into master Oct 8, 2026
18 checks passed
@tryuan99
tryuan99 deleted the titan/gravity_induced_drag branch October 8, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant