Ignore non expected confirm of command on client side - #3497
Merged
IntegratedQuantum merged 4 commits intoAug 30, 2026
Conversation
IntegratedQuantum
requested changes
Aug 8, 2026
| if (commands.popFront()) |cmd| { | ||
| try cmd.finalize(main.globalAllocator, .client, reader); | ||
| } else { | ||
| std.log.err("Received unexpected confirmation sync", .{}); |
Member
There was a problem hiding this comment.
Should return an error. Clients that are out of sync with the server should disconnect.
Contributor
Author
There was a problem hiding this comment.
returning an error is currently not hooked up to a disconnect on client side as it seems. I tried return error.Invalid and it would just ignore it then instead of doing a disconnect
Member
There was a problem hiding this comment.
As far as I can tell it should be hooked up. Could you investigate this further?
Contributor
Author
There was a problem hiding this comment.
I don't know what I tested 3 weeks ago, but return error.Invalid now works as expected
IntegratedQuantum
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normally this shouldn't happen, but I also see no reason to crash a client because of this