feat(lyrics): support LRC timestamps exceeding one hour - #2778
Open
GeorgeClensy wants to merge 1 commit into
Open
feat(lyrics): support LRC timestamps exceeding one hour#2778GeorgeClensy wants to merge 1 commit into
GeorgeClensy wants to merge 1 commit into
Conversation
Updated the lyrics utility to correctly parse and format LRC timestamps for tracks longer than 60 minutes. - Updated `LRC_LINE_REGEX`, `LRC_WORD_REGEX`, and related patterns to support an optional hour component `[HH:MM:SS.xx]` and handle variable-length minute fields. - Modified `parseLyrics` to extract and include hours in the total millisecond calculation for both lines and individual words. - Updated `syncedToLrcString` to conditionally format timestamps using the `[HH:MM:SS.xx]` format when the duration exceeds one hour. - Added unit tests covering extended minute formats (e.g., `[70:00.00]`), explicit hour formats, and word-by-word synchronization for long tracks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the lyrics utility to correctly parse and format LRC timestamps for tracks longer than 60 minutes.
LRC_LINE_REGEX,LRC_WORD_REGEX, and related patterns to support an optional hour component[HH:MM:SS.xx]and handle variable-length minute fields.parseLyricsto extract and include hours in the total millisecond calculation for both lines and individual words.syncedToLrcStringto conditionally format timestamps using the[HH:MM:SS.xx]format when the duration exceeds one hour.[70:00.00]), explicit hour formats, and word-by-word synchronization for long tracks.It now correctly recognises lyric time stamps for tracks over an hour. I have tested it with tracks over an hour and under an hour and they all show lyrics correctly. The tests all pass.
Before:
After:
