Skip to content

Disable backend-sim workflow, remove generated files, fix CORS misconfiguration - #1

Merged
PkLavc merged 1 commit into
mainfrom
copilot/update-github-actions-trigger
May 19, 2026
Merged

PkLavc merged 1 commit into
mainfrom
copilot/update-github-actions-trigger

Conversation

Copilot AI commented May 19, 2026

Copy link
Copy Markdown
Contributor

The backend-sim workflow was committing auto-generated simulation data (api/status.json, api/history.json) to the repo on a 6-hour schedule and via manual dispatch. Additionally, proxy.py had an invalid CORS configuration pairing allow_origins=["*"] with allow_credentials=True, which browsers reject per the CORS spec.

Changes

  • backend-sim.yml — Replaced schedule + workflow_dispatch triggers with on: workflow_call: (never invoked), effectively disabling the workflow while keeping valid YAML. Original triggers preserved in comments for easy re-enabling.
  • api/status.json, api/history.json — Deleted workflow-generated files and the now-empty api/ directory.
  • proxy.py — Set allow_credentials=False to fix the wildcard-origin + credentials CORS conflict:
# Before — browsers reject this combination
app.add_middleware(CORSMiddleware, allow_origins=["*"], allow_credentials=True, ...)

# After
app.add_middleware(CORSMiddleware, allow_origins=["*"], allow_credentials=False, ...)

@PkLavc
PkLavc marked this pull request as ready for review May 19, 2026 12:08
@PkLavc
PkLavc merged commit 4faad2b into main May 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants