Repository navigation
Disable backend-sim workflow, remove generated files, fix CORS misconfiguration - #1
Merged
Merged
Conversation
…CORS bug Agent-Logs-Url: https://github.com/PkLavc/cipher-gate/sessions/bb7a5c0c-8d1e-4717-9bb9-835f08da3e4c Co-authored-by: PkLavc <163757335+PkLavc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
backend-simworkflow was committing auto-generated simulation data (api/status.json,api/history.json) to the repo on a 6-hour schedule and via manual dispatch. Additionally,proxy.pyhad an invalid CORS configuration pairingallow_origins=["*"]withallow_credentials=True, which browsers reject per the CORS spec.Changes
backend-sim.yml— Replacedschedule+workflow_dispatchtriggers withon: workflow_call:(never invoked), effectively disabling the workflow while keeping valid YAML. Original triggers preserved in comments for easy re-enabling.api/status.json,api/history.json— Deleted workflow-generated files and the now-emptyapi/directory.proxy.py— Setallow_credentials=Falseto fix the wildcard-origin + credentials CORS conflict: