Repository navigation
Move pre-commit from runtime dependencies to the dev group - #100
Merged
Merged
Conversation
pre-commit is only used for local hooks and CI, but listing it as a runtime dependency pulls pre-commit -> virtualenv -> packaging into every install. In Pyodide/stlite, latest virtualenv requires packaging>=26.3, which conflicts with Streamlit's packaging<26 and intermittently breaks PMO Builder startup. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kathrynmurie
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pre-commitwas listed under[project].dependencies, so every install ofpmotoolspulled inpre-commit→virtualenv→packaging. Nothing insrc/imports it; it's only used for git hooks and CI. This moves it to thedevdependency group and regeneratesuv.lock.Why
PMO Builder runs
pmotoolsin the browser via stlite/Pyodide. The latestvirtualenv(21.x) requirespackaging>=26.3, while stlite's Streamlit requirespackaging<26. micropip resolves requirements concurrently, so app startup intermittently fails with:Impact
Requires-Distis nowpandas,biopython,jsonschema,openpyxl.uv sync/uv sync --devinstall thedevgroup, souv run pre-commit ...still works.pip install pmotoolsto getpre-commitwill need to install it separately.Testing
uv run pytest: 264 passeduv run pre-commit run --all-files: all hooks passpre-commitis gone from its metadata🤖 Generated with Claude Code