Fix incorrect encounters in Gen IV games

[Machine-Maker]

Change description

The commit ef10632 was not implemented correctly. It incorrectly put a bunch of SoulSilver encounters in the platinum game, leading to encounter confusion (platinum showed a lapras encounter in union cave, a location only in HG/SS for example).

It also added a incorrect "event arceus in party" to the HG lapras encounter. It added it to one-to-many encounters, not just the ones it meant to.

You can see in the original commit, encounters added for games 14 and 15, but 14 is platinum.

AI coding assistance disclosure

Claude helped me find the issue after I noticed the errant Lapras encounter

Contributor check list

• I have written a description of the contribution and explained its motivation.
• I have written tests for my code changes (if applicable).
• I have read and understood the AI Assisted Contribution guidelines.
• I will own this change in production, and I am prepared to fix any bugs caused by my code change.

[jemarq04]

Good catch! Your changes are good, I just noticed an issue with the pre-existing pokemon IDs if you can fix that up. Thanks!

[Machine-Maker]

fixed

[jemarq04]

Great, looks good. Please also sync it with the master branch - if you have some difficulties let me know, as I was also experiencing some issues with that using git. I've had to sync with GitHub lately.

[Machine-Maker]

Done

[Machine-Maker]

I added another fix. There was no Giratina encounters at all in platinum, when there are 2 (one conditional on not having done the first).

[Naramsim]

Thanks!

[pokeapi-machine-user]

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

[pokeapi-machine-user]

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).