Add Language of Origin reading for Home - #1459
Merged
Merged
Conversation
Add language of origin reading for Home
Collaborator
|
Tests are still failing after merging Packages. Can you try rebasing? |
Collaborator
|
Not sure why tests are still failing. Are they genuinely broken? |
Member
Author
|
They all pass locally for both Tesseract and Paddle |
Member
Author
|
I should have time tonight to dive into the logs and figure out what the issue is. |
Member
Author
|
Tests are passing now. I had accidentally renamed some of the test images locally then built the new test entries from those names. Just needed to fix the paths to what is actually out in CommandLineTests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a method to Summary Reader for reading the Language of Origin.
Dependent on PokemonAutomation/Packages#85
Not currently used by any home program. Will add to the regular home sorter once Home OCR is more stable