Repository navigation
Publish the capital gains tax reform dashboard at /uk/cgt-reform - #1318
Draft
vahid-ahmadi wants to merge 1 commit into
Draft
vahid-ahmadi wants to merge 1 commit into
vahid-ahmadi wants to merge 1 commit into
Conversation
Adds an iframe app entry (slug cgt-reform), a zone route to the Vercel deployment of PolicyEngine/uk-cgt-reform, and a 1024x683 cover image reused from the 2024 CGT Autumn Budget post. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publishes the capital gains tax reform dashboard at
/uk/cgt-reform, the same way as the childcare dashboard (#1250).Live deployment: https://uk-cgt-reform.vercel.app/uk/cgt-reform
Source: PolicyEngine/uk-cgt-reform
Important
Do not merge yet. Merge only after the uk-cgt-reform release-line PRs (PolicyEngine/uk-cgt-reform#10 plus the two PRs stacked on it: PolicyEngine/uk-cgt-reform#16 (certified-data and pe-uk re-pin) and PolicyEngine/uk-cgt-reform#15 (wording and formatting); #13 is parked until after the Budget, and the re-pin PR supersedes #14) are merged and the Modal backend has been redeployed and re-warmed. If that cannot happen first, hide the Rate explorer tab before this goes live. The tab scores schedules on the Modal backend, so a stale or cold backend would surface on policyengine.org.
What it covers
The dashboard estimates reforms to UK capital gains tax rates from 2026-27. It shows:
Changes
app/src/data/apps/apps.json: iframe entry (slugcgt-reform, title "Aligning capital gains tax rates with income tax", authorvahid-ahmadi, imagecgt-reform.jpg). The description avoids naming an elasticity source, because Follow CenTax's elasticity, model Business Asset Disposal Relief as a policy, and name the reform by what it does uk-cgt-reform#10 and Compare two approaches to income shifting in the behavioural response uk-cgt-reform#11 change it.website/src/data/appZoneRoutes.ts: zone route to the Vercel deployment. The dashboard is built with basePath/uk/cgt-reform;withDeepRouteadds the/:path*rewrite.app/public/assets/posts/cgt-reform.jpg: cover image (1024×683, 3:2, as in Publish the childcare cliff edge dashboard at /uk/childcare-100k-threshold #1250), reused from the November 2024 CGT Autumn Budget post (cgt-autumn-budget.webp).To do before ready
dateinapps.jsonto the publication date (now 2026-10-19).Multizone audit of the zone
Run against uk-cgt-reform
mainat 328cb03 and the live deployment:/uk/cgt-reformis a literal, noassetPrefix(correct for a server-rendered zone), novercel.jsonrewrites needed._next/staticassets and the/api/exploreroute resolve under the basePath.<a>tags; there is nonext/link.app/icon.*, so the zone's own domain has no favicon (behind the host, the host's favicon rewrite covers it). The zone uses its own header and@policyengine/design-systemrather than@policyengine/ui-kit./uk/equalising-cgtto/uk/cgt-reform, but only on the Vercel domain. This PR does not route/uk/equalising-cgton policyengine.org, which never served it.Checks
website: eslint and prettier pass onappZoneRoutes.ts;tsc --noEmitpasses. Vitest reports 4 time-zone failures (postDate,home-blog-preview-dates), and the same 4 fail onmainat d756930.app:tsc --noEmitpasses. The app-data and OG tests (appTransformers,postTransformers,middleware/og*,api/og) report 12 failures inogHandlers.test.ts, and the same 12 fail onmainat d756930, so this change does not cause them.🤖 Generated with Claude Code